Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666763 --- Comment #12 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-01-05 13:19:05 EST --- (In reply to comment #10) > - Don't know what's wrong with permissions set to 664 (or 644) on the source > archive ??? I suggest just to change the file permissions to 644 in the srpm. It makes rpmlint happy and doesn't hurt as install assigns the proper permissions anyway. > - Why should I strip binaries ? To loose debugging information when at the end > it is compiled with it ? You should not strip the binaries manually. rpmbuild does that automatically when creating the debuginfo package. Obviously, your rpmbuild utility behaves a bit different. > - What's wrong with the config file being place in /etc/sysconfig (is there a > list of known config files somewhere, that is not listing mine ?) ? config files must be marked with %config(noreplace) or plain %config. See http://fedoraproject.org/wiki/PackagingGuidelines#Configuration_files > - Fixed the init script with empty Required-Start and Required-Stop; in the > end, the only thing that is required is that the (kiss) interface has been > configured with kissattach or something equivalent to that; it doesn't even > need the network interface to be up (such as ax0); OK. You should also have a look at http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscript_packaging and adapt the iniscript and the spec file accordingly. > - It's really pointless to provide a manual page for the daemonizer script > (by the way, do you have any better idea on how to "daemonize" without > touching the source files ?); The warning about the missing manpage can be ignored, of course. > - The service is enabled by default, otherwise ? Who decides what is good and > what is bad ? The Fedora guidelines want the packagers not to start services by default. See http://fedoraproject.org/wiki/Packaging/SysVInitScript#Why_don.27t_we.... > - Manual page not compressed in bzip2 ?? No idea. You don't even have got > that, Martin. Something to do with upstream rpmlint 1.0 that I am using. Fedora's rpmbuild compresses manpages by default. So no action is required here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review