[Bug 666633] Review Request: liblastfmlib - library providing implementation of LastFm Submission Protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=666633

--- Comment #6 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2011-01-05 10:44:12 EST ---
Good:
+ remove empty TODO file
* Local build works fine
* Package contains no patches
* Files permissions are ok on %files and %doc stanza

Bad:
- Please remove the BRs to automake and autoconf. Automake is only requires, if
you make a patch to the Makefile.am file and want to recreate the makefile.in
file. autoconf is only required, if you want to patch the configure.ac or
configure.in file and recreating the configure script.

Please bump the release number of your package, if you are uploading a new
release of your package for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]