Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Image-Color - Manage and handles color data and conversions Alias: pear-Image-Color https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218229 ------- Additional Comments From Fedora@xxxxxxxxxxxxxxxxx 2006-12-07 13:50 EST ------- This package is used by php-pear-Image-Canvas in which tests works (so this package works). REVIEW * source files match upstream: a4a1a6f5c0f72d235930902cc1ee2e94 /tmp/Image_Color-1.0.2.tgz a4a1a6f5c0f72d235930902cc1ee2e94 SOURCES/Image_Color-1.0.2.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible (PHP). * latest version is being packaged (1.0.2) * BuildRequires are proper. * %clean is present. * package builds in mock (development). * package installs properly * rpmlint is silent. * final provides are sane: php-pear(Image_Color) = 1.0.2 php-pear-Image-Color = 1.0.2-1.fc7 * %check is not present; no test suite provide. * owns the directories it creates (see comment) * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear install) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. Should : remplace in %file %{pear_phpdir}/* by %{pear_phpdir}/Image More explicit and allow detection of new directory in next release (testdir p.e.) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review