Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664204 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-01-04 10:57:55 EST --- (In reply to comment #2) > Source tar ball is original. Ok. > Summary verified from lib/BackPAN/Index.pm. Ok. > License verified from lib/BackPAN/Index.pm. Ok. > Description verified from lib/BackPAN/Index.pm. Ok. Continuation: FIX: BuildRequire perl(File::Spec) (t/lib/TestUtils.pm:6) as it can dual-live in the future (http://search.cpan.org/~smueller/PathTools/). FIX: BuildRequire perl(File::Path) (t/lib/TestUtils.pm:7) as it can dual-live in the future (http://search.cpan.org/~dland/File-Path/). FIX: BuildRequire perl(URI::file) (t/lib/TestUtils.pm:28) FIX: BudilRequire perl(File::Spec::Unix) (t/lib/TestUtils.pm:29) Test::Pod::Coverage >= 1.04 (t/pod_coverage.t:4) unused in standard test run. Ok. Obsoletes on package rename. Ok. All tests pass. Ok. $ rpmlint perl-BackPAN-Index.spec ../SRPMS/perl-BackPAN-Index-0.39-1.fc14.src.rpm ../RPMS/noarch/perl-BackPAN-Index-0.39-1.fc14.noarch.rpm perl-BackPAN-Index.noarch: W: obsolete-not-provided perl-Parse-BACKPAN-Packages 2 packages and 1 specfiles checked; 0 errors, 1 warnings. As perl package dependency is denoted by `perl()' schema and this package provides perl(Parse::BACKPAN::Packages) = 0.39, this is sufficient. rpmlint Ok. $ rpm -pqlv ../RPMS/noarch/perl-BackPAN-Index-0.39-1.fc14.noarch.rpm drwxr-xr-x 2 root root 0 led 4 16:18 /usr/share/doc/perl-BackPAN-Index-0.39 -rw-r--r-- 1 root root 1888 dub 17 2010 /usr/share/doc/perl-BackPAN-Index-0.39/CHANGES -rw-r--r-- 1 root root 18426 dub 17 2010 /usr/share/doc/perl-BackPAN-Index-0.39/LICENSE -rw-r--r-- 1 root root 5771 dub 17 2010 /usr/share/doc/perl-BackPAN-Index-0.39/README drwxr-xr-x 2 root root 0 led 4 16:18 /usr/share/doc/perl-BackPAN-Index-0.39/examples -rw-r--r-- 1 root root 1872 led 4 16:18 /usr/share/doc/perl-BackPAN-Index-0.39/examples/backpan.pl -rw-r--r-- 1 root root 3906 led 4 16:18 /usr/share/man/man3/BackPAN::Index.3pm.gz -rw-r--r-- 1 root root 2176 led 4 16:18 /usr/share/man/man3/BackPAN::Index::Dist.3pm.gz -rw-r--r-- 1 root root 2418 led 4 16:18 /usr/share/man/man3/BackPAN::Index::File.3pm.gz -rw-r--r-- 1 root root 2570 led 4 16:18 /usr/share/man/man3/BackPAN::Index::Release.3pm.gz -rw-r--r-- 1 root root 2067 led 4 16:18 /usr/share/man/man3/BackPAN::Index::Role::AsHash.3pm.gz -rw-r--r-- 1 root root 1776 led 4 16:18 /usr/share/man/man3/BackPAN::Index::Schema.3pm.gz -rw-r--r-- 1 root root 2979 led 4 16:18 /usr/share/man/man3/Parse::BACKPAN::Packages.3pm.gz drwxr-xr-x 2 root root 0 led 4 16:18 /usr/share/perl5/BackPAN drwxr-xr-x 2 root root 0 led 4 16:18 /usr/share/perl5/BackPAN/Index -rw-r--r-- 1 root root 16570 led 4 16:18 /usr/share/perl5/BackPAN/Index.pm -rw-r--r-- 1 root root 1768 led 4 16:18 /usr/share/perl5/BackPAN/Index/Dist.pm -rw-r--r-- 1 root root 2311 led 4 16:18 /usr/share/perl5/BackPAN/Index/File.pm -rw-r--r-- 1 root root 2588 led 4 16:18 /usr/share/perl5/BackPAN/Index/Release.pm drwxr-xr-x 2 root root 0 led 4 16:18 /usr/share/perl5/BackPAN/Index/Role -rw-r--r-- 1 root root 1003 led 4 16:18 /usr/share/perl5/BackPAN/Index/Role/AsHash.pm -rw-r--r-- 1 root root 567 led 4 16:18 /usr/share/perl5/BackPAN/Index/Schema.pm drwxr-xr-x 2 root root 0 led 4 16:18 /usr/share/perl5/Parse drwxr-xr-x 2 root root 0 led 4 16:18 /usr/share/perl5/Parse/BACKPAN -rw-r--r-- 1 root root 5245 led 4 16:18 /usr/share/perl5/Parse/BACKPAN/Packages.pm File permissions and layout Ok. $ rpm -pq --requires ../RPMS/noarch/perl-BackPAN-Index-0.39-1.fc14.noarch.rpm |sort |uniq -c 1 perl(App::Cache) >= 0.37 1 perl(Archive::Extract) 1 perl(autodie) 1 perl(BackPAN::Index) 1 perl(BackPAN::Index::Role::AsHash) 1 perl(BackPAN::Index::Schema) 1 perl(base) 1 perl(CLASS) 1 perl(Class::Accessor::Fast) 1 perl(CLASS) >= 1.00 1 perl(CPAN::DistnameInfo) >= 0.09 1 perl(DBD::SQLite) >= 1.25 1 perl(DBIx::Class::Schema::Loader) >= 0.05003 1 perl(DBIx::Class) >= 0.08109 1 perl(File::Basename) 1 perl(File::stat) 1 perl(LWP::Simple) 1 perl(:MODULE_COMPAT_5.12.2) 1 perl(parent) 1 perl(Path::Class) 1 perl(Path::Class) >= 0.17 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 2 rpmlib(VersionedDependencies) <= 3.0.3-1 TODO: Filter underspecified perl(CLASS) Requires. TODO: Filter underspecified perl(Path::Class) Requires. $ rpm -pq --provides ../RPMS/noarch/perl-BackPAN-Index-0.39-1.fc14.noarch.rpm |sort |uniq -c 1 perl(BackPAN::Index::Dist) 1 perl(BackPAN::Index::File) 1 perl(BackPAN::Index::Release) 1 perl(BackPAN::Index::Role::AsHash) 1 perl(BackPAN::Index::Schema) 1 perl(BackPAN::Index) = 0.39 1 perl-BackPAN-Index = 0.39-1.fc14 1 perl(Parse::BACKPAN::Packages) = 0.39 Binary provides Ok. $ resolvedeps-f15 ../RPMS/noarch/perl-BackPAN-Index-0.39-1.fc14.noarch.rpm Binary dependencies resolvable. Ok. Package does not build in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2700482) because of bug in perl-DBI. POSTPONE: This review will be suspended until fix of the perl-DBI in F15. Otherwise package is in line with Fedora and perl packaging guidelines. Please correct all `FIX' prefixed issues and submit new spec file. Please consider fixing all `TODO' prefixed issues. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review