Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666763 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-01-03 15:08:47 EST --- Hi Guido, since this is your first package submission, you need a sponsor who approves you. Thus, add FE-NEEDSPONSOR to the Blocks field above, and see the following web pages for further information: https://fedoraproject.org/wiki/PackageMaintainers/Join https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group Here are some quick comments on your spec file: - use macro %{version} in Source0 to simplify future updates - According to COPYRIGHT, the license is GPLv3+ (because of the addition "or (at your option) any later version"). This should be reflected in the License field. - drop BR: autoconf automake as both packages are picked up automatically - drop Requires: libax25, ncurses (the dependency is detected automatically) - drop INSTALL from %files (not needed in a binary package) - drop empty file NEWS $ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm ax_emergency_listen.x86_64: E: explicit-lib-dependency libax25 ax_emergency_listen.x86_64: E: zero-length /usr/share/doc/ax_emergency_listen-1.3.2/NEWS 3 packages and 0 specfiles checked; 2 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review