Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666222 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |a.badger@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |a.badger@xxxxxxxxx --- Comment #5 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2010-12-30 18:35:10 EST --- NEEDSWORK Good: * rpmlint: python-speaklater.noarch: W: spelling-error Summary(en_US) gettext -> get text, get-text, getter python-speaklater.src: W: spelling-error Summary(en_US) gettext -> get text, get-text, getter 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Those are ignorable * named according to the guidelines * spec file matches package name * license is BSD in spec and package itself which is an approved free software license * spec file is readable * Source matches upstream and upstream URL is canonical * No locales so no need for %find_lang * Not a C library * No bundled system libraries * Not relocatable * Package owns all files and directories it creates and nothing else * Permissions set properly * Macros used consistently * Code, not content * No large documentation files * Not a GUI application * All filenames valid UTF-8 MUST FIX: * Package does not build in koji : Package builds in koji - The reason is related to the %install section that I'll explain below. Should do: * I see that upstream has a LICENSE and a README file in their git repository. You should send them an email to have them include those in their releases. They probably need a MANIFEST.in file that lists those (something like: MANIFEST.in: include README LICENSE Notes: There's a couple non-Fedora-standard things in here. One of those is contributing to the build failure. This page https://fedoraproject.org/wiki/Packaging:Python has the python-specific guidelines for Fedora. If you take a look you'll see that your %install section and %files section are a bit different. In this section, it recommends not to use --record=INSTALLED_FILES https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling. In this section, there's a simple example of what the install section should look like: https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Eggs_using_Setuptools (sorry it's hidden away and the more complex python2/python3 spec is on the main page.) Basically instead of this: %{__python} setup.py install --single-version-externally-managed -O1 --root=%{buildroot} --record=INSTALLED_FILES [..] %files -f INSTALLED_FILES You should have this: %{__python} setup.py install --root=%{buildroot} [..]] %files %{python_sitelib}/* The reason that this is contributing to a build failure is that the setup.py file is conditionally using setuptools to build. When it uses setuptools, --single-version-externally-managed is a valid command line option. When it only uses distutils, that option is not available. You could BuildRequire: setuptools to fix that but it's simpler to just make the setup.py install line reflect what the guidelines suggest which works with both distutils and setuptools. If you fix those things, I can try building in koji again and approve this package. As discussed on IRC, you're also looking at reviewing a package and then I'll sponsor you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review