Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666190 --- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-12-30 05:53:22 EST --- Same issues as in bug 653971 (OpenFetion review): * Unowned directories: %{_datadir}/openfetion/ %{_datadir}/openfetion/resource/ http://fedoraproject.org/wiki/Packaging:UnownedDirectories > Summary: Library files of Openfetion Rather terse and unclear, IMO. It's likely that a lib* package contains library files, and obviously somebody who would search for "fetion" will find libofetion. Is this library attractive to other people, too? What parts of the Fetion protocol does it implement? E.g. | Summary: Instant messaging client library for the Fetion protocol V4 > %description > Fetion is an instant messaging (IM) client developed > by China Mobile, [...] But this is libofetion for OpenFetion, so the description ought to start with explaining what _this_ package contains. A few sentences later it could comment on the relationship with the original Fetion or the Fetion Protocol V4. > %setup -q -n %{name}-%{version} Option -n %{name}-%{version} is the default. No need to add it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review