[Bug 665995] Review Request: fmit - Free Music Instrument Tuner

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665995

--- Comment #7 from Volker FrÃhlich <volker27@xxxxxx> 2010-12-29 14:46:10 EST ---
You are right, it therefore isn't necessary to have a shared lib.

To avoid -DBUILD_SHARED_LIBS=OFF, three CMakeLists.txt must be modified. They
should declare the libraries static: Just add "STATIC" to ADD_LIBRARY as shown
below:

ADD_LIBRARY(fmit_modules ${fmit_MODULE_SRCS_MOC} ${fmit_MODULE_SRCS})
ADD_LIBRARY(fmit_modules STATIC ${fmit_MODULE_SRCS_MOC} ${fmit_MODULE_SRCS})

I don't think it is necessary to finish the review though. Please inform
upstream about it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]