Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652085 --- Comment #8 from HaÃkel GuÃmar <karlthered@xxxxxxxxx> 2010-12-28 16:11:40 EST --- * devel subpackages should require their non-devel counterpart. * since you use %cmake macro, you don't need to set CMAKE_INSTALL_PREFIX, CMAKE_INSTALL_LIBDIR or LIB_INSTALL_DIR (rpm --eval %cmake will tell which options are already enabled). You could probably drop the VERBOSE=1 as we set CMAKE_VERBOSE_MAKEFILE. * to improve spec readability, avoid lines longer than 80 columns or any reasonnable limit. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review