Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645277 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-12-27 13:46:14 EST --- > License: GPLv2 App's Help dialog says "GPLv2", but multiple source files are GPLv2+. Hence the full tag would be "GPLv2 and GPLv2+": $ grep "any later version" * -R|grep .py puddlestuff/tagmodel.py:#(at your option) any later version. puddlestuff/puddlesettings.py:#(at your option) any later version. puddlestuff/findfunc.py:#(at your option) any later version. puddlestuff/actiondlg.py:#(at your option) any later version. puddlestuff/puddleobjects.py:#(at your option) any later version. puddlestuff/audioinfo/ogg.py:#(at your option) any later version. puddlestuff/audioinfo/__init__.py:#(at your option) any later version. puddlestuff/audioinfo/musepack.py:#(at your option) any later version. puddlestuff/audioinfo/flac.py:#(at your option) any later version. puddlestuff/audioinfo/mp4.py:#(at your option) any later version. puddlestuff/audioinfo/apev2.py:#(at your option) any later version. puddlestuff/audioinfo/wma.py:#(at your option) any later version. puddlestuff/audioinfo/wavpack.py:#(at your option) any later version. puddlestuff/audioinfo/util.py:#(at your option) any later version. puddlestuff/helperwin.py:#(at your option) any later version. puddlestuff/webdb.py:#(at your option) any later version. > URL: http://puddletag.sourceforge.net 0.9.11 has been released. > BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Note that several details related to BuildRoot are no longer needed since Fedora 13: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag > Requires: python >= 2.5 This one is wrong actually, since the dep on python(abi) is automatic already and Python is newer than 2.5 for current Fedora dists anyway: $ rpm -qpR puddletag-0.9.7-1.fc14.noarch.rpm|grep abi python(abi) = 2.7 > Requires: PyQt4 > Requires: pyparsing >= 1.5.5 > Requires: python-mutagen > Requires: python-imaging > Requires: python-configobj > Requires: python-musicbrainz2 Even if it may be known that dependencies on Python modules are not automatic, the spec file ought to explain that in a comment: https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires e.g. # Dependencies on Python modules are not automatic yet. Requires: PyQt4 [...] > %description > Puddletag is a audio tag editor. ...is an audio tag editor. > %setup -q > %{__chmod} 0644 NEWS > %{__sed} -i -e '1d' \ > puddlestuff/{webdb,puddlesettings,puddletag,puddleobjects,releasewidget}.py This sed command is unacceptable IMO. You should at least use a proper match that guards against deleting unexpected changes in those files. Currently, there is a hashbang in those files. You cannot assume that future updates of the package won't be missing the hashbang. In that case you would either delete the UTF-8 encoding or valid code. > %files [...] > %{python_sitelib}/puddlestuff As a hint, more readable is to add a trailing slash to make clear that this is a directory tree and not a single file: %{python_sitelib}/puddlestuff/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review