Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=658942 Volker FrÃhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |volker27@xxxxxx --- Comment #1 from Volker FrÃhlich <volker27@xxxxxx> 2010-12-26 10:05:42 EST --- Just some comments: Please align the columns (Name, Group, License, ...). chmod and cp don't belong in the build section, but in prep. Don't delete the empty build section though. I already suggested at another review, rather to delete the text files than to exclude them. See https://bugzilla.redhat.com/show_bug.cgi?id=646611#c3 chmod and cp don't belong in the build section, but in prep. Don't delete the empty build section though. There are many more files that have executable permissions, but shouldn't. Also see the sub-directories! Please also take a look at "Kopie von schema.de.po", whether it's any use. Please try to get in contact with other Drupal module maintainers and decide on the version number style. CCK uses 6.x.2.8, while you are using 1.7. The license is stated nowhere in the code, and I also can't find it on the project's page. If you can't find out either, please clarify the license with the author and attach his statement as %doc. You may also consider to define another macro instead of drupaldir: %{_datadir}/drupal/modules/schema, because that's the only way you're using it. Please also try to clean up the description. Enter linebreaks between the paragraphs, if you think that the whole description is necessary and useful. Lines may be up to 80 characters long. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review