Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662949 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR) --- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-12-25 04:21:53 EST --- Brief look at the spec file only (no full review): It is likely that some of these issues are reported by rpmlint, too, so please run rpmlint on the src.rpm package and the built rpms. > %define name freedups > %define version 0.6.14 > %define release 1%{?dist} > > Name: %{name} > Version: %{version} > Release: %{release} Why the extra redefinition? "Name:" defines %name, "Version:" defines %version, and "Release:" defines %release already. It's sufficient to just write: Name: freedups Version: 0.6.14 Release: 1%{?dist} > License: GPL https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#GPL_and_LGPL plus https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification since the license text is not included, and all that's there is the brief comment (from 2002?) that "GPL" is used. It cannot be assumed that it is GPLv2+. > BuildRoot: %{_tmppath}/%{name}--buildroot Note that several details related to the BuildRoot are not needed anymore since Fedora 13: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean > install -m755 %{name}.pl $RPM_BUILD_ROOT%{_bindir}/%{name} Typically, option -p is used for "install" or "cp" to preserve timestamps. Less useful for files which change often, but added value for old files, so one can quickly notice the age of a file (e.g. ancient Documentation). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review