Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Test-Distribution - Perform tests on all modules of a distribution https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218721 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-12-06 21:02 EST ------- * source files match upstream: 64dc13f51f60f6022bb8e628f1297957 Test-Distribution-1.26.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Test::Distribution) = 1.26 perl(Test::Distribution::base) perl(Test::Distribution::description) perl(Test::Distribution::exports) perl(Test::Distribution::manifest) perl(Test::Distribution::pod) perl(Test::Distribution::podcover) perl(Test::Distribution::prereq) perl(Test::Distribution::sig) perl(Test::Distribution::use) perl(Test::Distribution::versions) perl-Test-Distribution = 1.26-1.fc7 = perl(:MODULE_COMPAT_5.8.8) perl(ExtUtils::Manifest) perl(File::Find::Rule) >= 0.03 perl(Module::CoreList) >= 1.93 perl(Module::Signature) perl(Pod::Coverage) >= 0.17 perl(Test::More) perl(Test::Pod) >= 0.95 perl(Test::Pod::Coverage) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: All tests successful, 6 subtests skipped. Files=9, Tests=46, 2 wallclock secs ( 0.89 cusr + 0.24 csys = 1.13 CPU) The skipped checks are due to either gpg failures due to missing keys (would probably require network access) or due to unimplemented tests. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review