Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Add iwl6000g2a-firmware - Firmware for Intel(R) Wireless WiFi Link 6005 Series Adapters https://bugzilla.redhat.com/show_bug.cgi?id=664763 Summary: Add iwl6000g2a-firmware - Firmware for Intel(R) Wireless WiFi Link 6005 Series Adapters Product: Fedora Version: 14 Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: iwl6000g2a-firmware AssignedTo: linville@xxxxxxxxxx ReportedBy: linville@xxxxxxxxxx QAContact: extras-qa@xxxxxxxxxxxxxxxxx CC: notting@xxxxxxxxxx, linville@xxxxxxxxxx, lemenkov@xxxxxxxxx, fedora-package-review@xxxxxxxxxx Depends on: 663737 Estimated Hours: 0.0 Classification: Fedora Target Release: --- Clone Of: 663737 Add this package to f14... +++ This bug was initially created as a clone of Bug #663737 +++ Spec URL: http://linville.fedorapeople.org/iwl6000g2a-firmware.spec SRPM URL: http://linville.fedorapeople.org/iwl6000g2a-firmware-17.168.5.1-1.fc14.src.rpm Description: This package contains the firmware required by the iwlagn driver for Linux to support the iwl6000g2a hardware. Usage of the firmware is subject to the terms and conditions contained inside the provided LICENSE file. Please read it carefully. --- Additional comment from lemenkov@xxxxxxxxx on 2010-12-17 05:28:52 EST --- I'll review it. --- Additional comment from lemenkov@xxxxxxxxx on 2010-12-19 03:48:22 EST --- Sorry for the delay - my home routed died almost after I post my last message in this ticket. Ok, here is my REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is almost silent sulaco ~: rpmlint ~/rpmbuild/RPMS/noarch/iwl6000g2a-firmware-17.168.5.1-1.fc12.noarch.rpm iwl6000g2a-firmware.noarch: W: spelling-error %description -l en_US iwlagn -> lagniappe, lasagna, lagging ^^^ this message should be ignored (false positive). 1 packages and 0 specfiles checked; 0 errors, 1 warnings. sulaco ~: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (Redistributable w/o modifications). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. sulaco ~/rpmbuild/SOURCES: sha256sum iwlwifi-6000g2a-ucode-17.168.5.1.tgz* e77b9a890cb9e57429995dea507a86fe710a13ff493210ba26a4ba05ae0e541a iwlwifi-6000g2a-ucode-17.168.5.1.tgz e77b9a890cb9e57429995dea507a86fe710a13ff493210ba26a4ba05ae0e541a iwlwifi-6000g2a-ucode-17.168.5.1.tgz.1 sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. I didn;t find any issues so this package is APPROVED. --- Additional comment from linville@xxxxxxxxxx on 2010-12-20 10:53:48 EST --- New Package SCM Request ======================= Package Name: iwl6000g2a-firmware Short Description: Firmware for Intel(R) Wireless WiFi Link 6005 Series Adapters Owners: linville Branches: f14 InitialCC: linville --- Additional comment from kevin@xxxxxxxxx on 2010-12-21 01:23:06 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review