Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664619 --- Comment #2 from Hicham HAOUARI <hicham.haouari@xxxxxxxxx> 2010-12-21 09:18:09 EST --- (In reply to comment #1) > Few notes from just a quick look: > * BuildRoot is not needed (ignore rpmlint warning) > * rm -rf $RPM_BUILD_ROOT and %clean section not needed (see above) - I think there is no harm in keeping that, in case we want to maintain a single spec across Fedora and EPEL > * line "%doc %{_javadocdir}/%{name}/*" in %files should be removed (duplicate > entry) > - I believe the first entry is for directory ownership only, the second marks the files as doc ones. > Other than that package looks OK (I haven't looked at the tarball though). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review