[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662301

--- Comment #5 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2010-12-21 06:11:50 EST ---
(In reply to comment #3)
> PREFIX is not useless when building plotdrop. 
> 
> CFLAGS uses DATADIR , DATADIR uses PREFIX. If you do not use PREFIX
> /usr/local/share will be come as your data directory. 
Absolutely right, sorry for my wrong remark, I missed the line in question in
the Makefile.

> SPEC URL:http://sagarun.fedorapeople.org/SPECS/plotdrop.spec
> 
> SRPM URL: http://sagarun.fedorapeople.org/SRPMS/plotdrop-0.5.3-2.fc13.src.rpm
As Terje said, you'd better use %{_prefix} than /usr/ explicitely.

rpmlint complains on empty debug:
   plotdrop-debuginfo.x86_64: E: empty-debuginfo-package
When installing the files, the Makefile call install with the -s option
(strip), that *must* be removed.
You can use the following sed command, in %prep too:
   sed -i "s/install -s/install/g" Makefile

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]