Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657577 --- Comment #1 from Volker FrÃhlich <volker27@xxxxxx> 2010-12-19 09:37:39 EST --- I assume, the hack is useless without SDL installed. Please require SDL. You may consider to build and install explicitly, since it requires about as many lines as the sed approach does. Writing "./build" and "./install" should be fine as well. Please give a rationale, why you choose to create an own directory for the library to install to. You can simplify the files section to: %{_bindir}/* %{_libdir}/%{name} %{_mandir}/man1/* I don't know if this package makes sense for EPEL. If you don't want to introduce it there, you can drop the buildroot, the clean section and the rm for buildroot in the install section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review