Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663817 --- Comment #3 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> 2010-12-19 01:13:31 EST --- (In reply to comment #2) > (In reply to comment #1) > > Almost ready; there are two small things that need fixing: > > > > - release number should have the snapshot date, VCS used and (preferably) > > commit hash > > Have you got a link to this documentation? Yes; forgot to include it: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages (see the subsection on snapshots, with SVN and Git examples) > > > - %install should start with the build root getting cleaned with rm -rf > > It my understanding is that with the %clean section this is no longer required. Ah, whoops. It's actually the BuildRoot change -- the %clean change just takes care of the post-building cleanup: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag So it's just the release number, and then this is good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review