[Bug 663983] Review Request: rubygem-boxgrinder-build-ec2-platform-plugin - BoxGrinder plugin to convert appliances to EC2 format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663983

--- Comment #4 from Marek Goldmann <mgoldman@xxxxxxxxxx> 2010-12-18 15:33:18 EST ---
I would say partially. boxgrinder-build-ec2-platform-plugin.rb file should
contain:

require 'boxgrinder-build/managers/plugin-manager'

On the other hand this plugin will be not used directly, like you tested it.
Instead it'll be initialized by this plugin manager so it'll not break. I added
it now to upstream git repo. It'll be pushed with next version - 0.0.8. IMHO
it's not a blocker for this package, WDYT?

P.S. You'll see same behavior for there submitted review requests (s3 plugin -
bug 664111, ebs plugin - bug 664113). Both also fixed in upstream git repo.

Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]