Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634909 Alex Hudson (Fedora Address) <fedora@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #23 from Alex Hudson (Fedora Address) <fedora@xxxxxxxxxxxxxx> 2010-12-18 08:59:04 EST --- Sorry for taking so long to pick this up again; I've been a bit ill this last week :( rpmlint outputs: $ rpmlint SPECS/v8.spec SPECS/v8.spec: W: invalid-url Source0: v8-3.0.0.1.tar.gz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. $ rpmlint SRPMS/v8-3.0.0.1-2.fc14.src.rpm v8.src: W: invalid-url Source0: v8-3.0.0.1.tar.gz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint RPMS/x86_64/v8-3.0.0.1-2.fc14.x86_64.rpm v8.x86_64: W: shared-lib-calls-exit /usr/lib64/libv8-3.0.0.1.so exit@xxxxxxxxxxx v8.x86_64: W: no-manual-page-for-binary js2c v8.x86_64: W: no-manual-page-for-binary d8 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint RPMS/x86_64/v8-devel-3.0.0.1-2.fc14.x86_64.rpm v8-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint RPMS/x86_64/v8-debuginfo-3.0.0.1-2.fc14.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. No errors, and the warnings have already been accounted for. No problems there. Going through the review guidelines again: * Does not comply with ExcludeArch MUST, see c19. * All other MUST complied with. I can't find any other issues with the packages, therefore it passes my review and I'm happy to approve v8. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review