[Bug 661436] Review Request: rubygem-heroku - deploy apps to Heroku

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661436

--- Comment #14 from Minnikhanov <minnikhanov@xxxxxxxxx> 2010-12-17 14:13:21 EST ---
(In reply to comment #13)
> For 1.14.10-1:
> 
> * Duplicate entries
>   - build.log shows:
> -------------------------------------------------
>     62  warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/heroku-1.14.10
>     63  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/heroku-1.14.10/bin
>     64  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/heroku-1.14.10/bin/heroku
>     65  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/heroku-1.14.10/lib
>     66  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/heroku-1.14.10/lib/heroku
>     67  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/heroku-1.14.10/lib/heroku-postgresql
>     68  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/heroku-1.14.10/lib/heroku-postgresql/client.rb
> ...
> ...
> -------------------------------------------------
>     Note that %files entry
> -------------------------------------------------
> %files
> %{geminstdir}/
> -------------------------------------------------
>     contains the directory %geminstdir itself and all files/directories/etc
>     under this directory, and this entry is now no longer needed.
> 
> * Documents
>   - Please move README.md to main package (from -doc subpackage) because
>     this file contains license information.
> 
> 
> By the way are you already sponsored? If not, do you have
> another review request submission?

Fix all notes.

Spec URL:
http://dl.dropbox.com/u/14118661/rubygem-heroku.spec
SRPM URL:
http://dl.dropbox.com/u/14118661/rubygem-heroku-1.14.10-1.fc14.src.rpm

At github (don't download by 'wget')
> Spec URL:
> https://github.com/minn/rubygem/blob/master/heroku/rubygem-heroku.spec
> SRPM URL:
> https://github.com/minn/rubygem/blob/master/heroku/rubygem-heroku-1.14.10-1.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]