Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588941 --- Comment #36 from Dave Malcolm <dmalcolm@xxxxxxxxxx> 2010-12-17 12:23:19 EST --- (In reply to comment #35) > (In reply to comment #34) > > (In reply to comment #33) > > > JVM backend is not mature enough to be shipped. > > Thanks; we'll leave it out, then. > > > > > Btw: how did you end up having > > > those files in the first place? Only things that are needed for a binary are > > > ones that are packaged using package.py, which includes stdlib and .h files > > > (and that's about it). Do you put all the source code with the package? If so, > > > why? > > Sorry, it's not clear to me which files you're referring to in the above. > > > > The specfile is still using the scripted code from before; I haven't yet looked > > at the package.py you referred to. I plan to address this later today (note to > > self: comment #12 above). > > > > I'm referring to prebuilt jars. They should not be there in the binary > distribution at all, because the source code is not included (or a directory > where they live in). How did you get a list of files that has to be included? FWIW, those jar files are present within SVN/HG; looking here: http://codespeak.net/pypy/dist/pypy/translator/jvm/src/ I see them, and they seem to be in the source tarballs you're building: $ tar -tjvf pypy-1.4-src.tar.bz2 | grep jar -rw-r--r-- fijal/fijal 207224 2007-12-06 06:37 pypy-1.4/pypy/translator/jvm/src/jna.jar -rw-r--r-- fijal/fijal 128766 2009-04-18 11:54 pypy-1.4/pypy/translator/jvm/src/jasmin.jar $ md5sum pypy-1.4-src.tar.bz2 6c7e5a3fab4b3f6357aab84927420b49 pypy-1.4-src.tar.bz2 (which matches that on http://pypy.org/download.html ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review