Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554187 --- Comment #27 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-12-16 15:29:51 EST --- (In reply to comment #23) > Okay, I've grepped through the source code. It looks like there's no need to > list Public Domain now. But we do need to list Python since code under that > license is used in builtin.cpp. I think that this would be a proper License > tag and comment: > > # The dict implementation in shedskin/lib/builtin.cpp is under the Python > # license. The Murmurhash implementation in builtin.cpp is bundled (noted > # below) and licensed MIT. Other files in shedskin/lib/ are MIT, rest GPLv3 > License: GPLv3 and (MIT and Python) Thanks, Toshio, for looking. (In reply to comment #24) > Toshio is right; just fix the license field and you should be good to go. A > full review is attached. Thanks for the review. Fixed License in: SPEC: http://tomspur.fedorapeople.org/review/shedskin.spec SRPM: http://tomspur.fedorapeople.org/review/shedskin-0.7-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review