Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: MyBashBurn 1.0-1 - burn data and songs. Alias: MyBashBurn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197 ------- Additional Comments From bugs.michael@xxxxxxx 2006-12-05 17:51 EST ------- > %post > ln -s %{_datadir}/%{name}/MyBashBurn.sh %{_bindir}/mybashburn > /dev/null 2>&1 > ln -s %{_datadir}/%{name}/MyBashBurn.sh %{_bindir}/bashburn > /dev/null 2>&1 > > %postun > rm -f %{_bindir}/bashburn > rm -f %{_bindir}/mybashburn Why? This is extremely ugly. The files are not even %ghosted. They are not tracked in the RPM database. Why not simply create these links at build-time and include them in the package? That is the way it ought to be. > %files > %defattr(-,root,root,0755) > %{_datadir}/%{name}/* Directory %{_datadir}/%{name} is not included. Correct would be: %{_datadir}/%{name}/ Find one brief explanation in bug 165616 comment 8. > %doc COPYING CREDITS ChangeLog FAQ FILES HOWTO INSTALL README TODO Is the "INSTALL" file the typical NLS documentation which is irrelevant to users of your RPM package? If so, don't include it. It is confusing. > install -d %{buildroot}/usr/lib/debug What's this? Further, prefer "install" with option -p (or "cp" with option -p) to preserve timestamps wherever it is possible. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review