Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662604 --- Comment #1 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-12-15 07:59:43 EST --- Review for 194d2fae199c9f49dead1e45172c3e00 ibus-unikey-0.5.1-1.fc14.src.rpm OK - MUST: $ rpmlint /var/lib/mock/fedora-14-x86_64/result/ibus-unikey-* ibus-unikey.src: W: invalid-url Source0: http://ibus-unikey.googlecode.com/files/ibus-unikey-0.5.1.tar.gz HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Warning can be ignored, happens with all files on Google Code. I have verified the URL with spectool. OK - MUST: named according to the Package Naming Guidelines OK - MUST: spec file name matches the base package %{name} FIX - MUST: package does not meet the Packaging Guidelines, see below OK - MUST: Fedora approved license and meets the Licensing Guidelines (GPLv3) OK - MUST: License field in spec file matches the actual license OK - MUST: license file included in %doc OK - MUST: spec is in American English OK - MUST: spec is legible OK - MUST: sources match the upstream source by MD5 0b8f79941dc3e9a4744d52e88e4401dc OK - MUST: successfully compiles and builds into binary rpms on F14 x86_64 N/A - MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. OK - MUST: all build dependencies are listed in BuildRequires. FIX - MUST: does not handle locales properly with %find_lang, see below N/A - MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. OK - MUST: Package does not bundle copies of system libraries. N/A - MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. FIX - MUST: does not own all directories that it creates, see below OK - MUST: no duplicate files in the %files listing OK - MUST: Permissions on files are set properly, includes %defattr(...) OK - MUST: consistently uses macros OK - MUST: package contains code, or permissable content N/A - MUST: Large documentation files should go in a -doc subpackage OK - MUST: Files included as %doc do not affect the runtime of the application N/A - MUST: Header files must be in a -devel package N/A - MUST: Static libraries must be in a -static package N/A - MUST: library files that end in .so are in the -devel package. N/A - MUST: devel packages must require the base package using a fully versioned dependency OK - MUST: The package does not contain any .la libtool archives. N/A - MUST: Packages containing GUI applications must include a %{name}.desktop file. FIX - MUST: package does owns own files or directories already owned by other packages, seel below OK - Should: at the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT. OK - MUST: all filenames valid UTF-8 SHOULD Items: OK - SHOULD: Source package includes license text(s) as a separate file. N/A - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. OK - SHOULD: builds in mock. OK - SHOULD: compiles and builds into binary rpms on all supported architectures. OK - SHOULD: functions as described. OK - SHOULD: Scriptlets are sane. N/A - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg OK - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin N/A - SHOULD: package should contain man pages for binaries/scripts. Other items: OK - latest stable version OK - SourceURL valid OK - Compiler flags ok OK - Debuginfo complete OK - SHOULD: package has a %clean section, which contains rm -rf %{buildroot} ( or $RPM_BUILD_ROOT ). N/A - SHOULD: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. Issues: Use of %{_datadir}/locale/... is forbidden, use %find_lang instead. See https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files The package does not own all folders that is creates: %{_datadir}/%{name}/* will only own the files inside that folder, use %{_datadir}/%{name}/ instead. See https://fedoraproject.org/wiki/Packaging:UnownedDirectories The package owns the folder %{_datadir}/ibus/component/, which is already owned by the ibus package. Since ibus is a dependency of this package it should only own %{_datadir}/ibus/component/unikey.xml. See https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership The package does not build on F15, attaching a build.log. You might want to contact upstream about this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review