Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654139 Arun SAG <sagarun@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Arun SAG <sagarun@xxxxxxxxx> 2010-12-15 02:28:22 EST --- [+] OK [X] NOT OKAY [-] NA [+] Package meets naming and packaging guidelines [+] Spec file matches base package name. [+] Spec has consistant macro usage. [+] Meets Packaging Guidelines. [+] License [+] License field in spec matches [+] License file included in package [+] Spec in American English [+] Spec is legible. [+] Sources match upstream md5sum: [zer0c00l@gnubox SOURCES]$ md5sum ~/Downloads/ease-0.4.tar.bz2 9134b74a2ff3701b62d08f5b4d954232 /home/zer0c00l/Downloads/ease-0.4.tar.bz2 -- done [-] Package needs ExcludeArch [+] BuildRequires correct [+] Spec handles locales/find_lang [-] Package is relocatable and has a reason to be. [+] Package has %defattr and permissions on files is good. [-] Package has a correct %clean section. [-] Package has correct buildroot [+] Package is code or permissible content. [-] Doc subpackage needed/used. [-] Packages %doc files don't affect runtime. [+] Headers/static libs in -devel subpackage. [+] Spec has needed ldconfig in post and postun [X] .pc files in -devel subpackage/requires pkgconfig [+] .so files in -devel subpackage. [+] -devel package Requires: %{name} = %{version}-%{release} [+] .la files are removed. [+] Package is a GUI app and has a .desktop file [+] Package compiles and builds on at least one arch. [+] Package has no duplicate files in %files. [+] Package doesn't own any directories other packages own. [+] Package owns all the directories it creates. [+] No rpmlint output : ignorable [zer0c00l@gnubox i686]$ rpmlint ease-0.4-1.fc13.i686.rpm ease.i686: W: no-manual-page-for-binary ease 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [zer0c00l@gnubox i686]$ rpmlint ease-devel-0.4-1.fc13.i686.rpm ease-devel.i686: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [zer0c00l@gnubox i686]$ rpmlint ~/rpmbuild/SRPMS/ease-0.4-1.fc13.src.rpm ease.src:53: E: hardcoded-library-path in /usr/lib ease.src: W: no-cleaning-of-buildroot %clean ease.src: W: no-buildroot-tag ease.src: W: no-%clean-section Note: hardcoded-library-path in /usr/lib @ Line 53. Where the line is "sed -i 's|/lib /usr/lib|/lib /usr/lib /lib64 /usr/lib64|' libtool". It removes rpath. Not an error. SHOULD Items: [+] Should build in mock. [+] Should build on all supported archs [+] Should function as described. [-] Should have sane scriptlets. [-] Should have subpackages require base package with fully versioned depend. [+] Should have dist tag [+] Should package latest version [+] check for outstanding bugs on package. (For core merge reviews) XXX APPROVED XXX -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review