Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473046 --- Comment #29 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2010-12-14 13:08:50 EST --- Not sure if I'll get flamed for nitpicking again, but here are some comments: You should at least look at the rpmlint output and try to address what you can: miniupnpc.src: W: strange-permission upnpnats 0777L The file in the srpm is mode 777; not really a good idea. miniupnpc.src:54: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib I guess I understand that you're trying to avoid patching the makefile, but I'm curious why just doing make PREFIX=$RPM_BUILD_ROOT INSTALLDIRLIB=$RPM_BUILD_ROOT/%{_libdir} install doesn't work for you. miniupnpc.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9) No reason not to clean that up. miniupnpc.x86_64: W: incoherent-version-in-changelog 1.2-5.fc9 ['1.4-5.fc15', '1.4-5'] Don't include the dist tag in changelog entries. miniupnpc.x86_64: W: unstripped-binary-or-object /usr/lib64/libminiupnpc.so.4 This is odd; you'll need to investigate why this isn't being stripped properly. It looks like the compiler flags are correct (although most of them seem to be listed twice, so maybe there's some sort issue relating to that). Or maybe it has somethig to do with the static stuff. miniupnpc.x86_64: W: conffile-without-noreplace-flag /etc/sysconfig/upnpnats Needs to be %config(noreplace), not just %config, else it will be overwritten when the package is updated. miniupnpc.x86_64: W: no-manual-page-for-binary upnpc It is nice to have manual pages but it's not essential. miniupnpc.x86_64: W: service-default-enabled /etc/rc.d/init.d/upnpnats miniupnpc.x86_64: W: service-default-enabled /etc/rc.d/init.d/upnpnats The services should definitely not be enabled by default. miniupnpc.x86_64: E: incoherent-subsys /etc/rc.d/init.d/upnpnats upnpcnats miniupnpc.x86_64: W: incoherent-init-script-name upnpnats ('miniupnpc', 'miniupnpcd') These are OK; rpmlint is confused by the service name differing from the package name. This package includes a static library. If you really wish to include a static lib, you must follow http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries You are missing the the ldconfig dependencies for the scriptlets. There are some bits of the spec you can remove if you're only planning to target Fedora and RHEL6 or newer: BuildRoot, the first line of %install, and the entire %clean section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review