Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663058 --- Comment #1 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-12-14 10:53:16 EST --- Taking this for review: Overall this package looks safe to me, just one issue, please fix wrong email in %changelog section. Formal review: * Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification. PASS * The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version FAILED: Please fix it using: http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem * The package must have a Requires and a BuildRequires on rubygems PASS * The %prep and %build sections of the specfile should be empty. PASS * The Gem must be installed into %{gemdir} defined as %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) PASS * The install should be performed with the command gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} PASS * The package must own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec PASS * If the Gem only contains pure Ruby code, it must be marked as BuildArch: noarch. PASS -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review