Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662951 --- Comment #1 from Xavier Bachelot <xavier@xxxxxxxxxxxx> 2010-12-14 10:37:34 EST --- I'm not a sponsor but from a quick glance, here are a couple comments that will hopefully help. - Don't define version and release twice. Just use plain "Version: 1.2.3", for example. - Source0 must be a full URL. - BuildRequires/Obsolotes/Provides for perl-MDK-Common looks dubious and are probably uneeded for the Fedora package. - Why disable AutoReqProv ? - %defattr should be %defattr(-,root,root,-) - Watch out for potentially unowned files/dirs or missing Requires (%{_datadir}/vim/ftplugin ; %{_sysconfdir}/emacs/site-start.d) - You might want to trim the changelog not too include the full Mandriva history. It is obviously fine to keep a comment about the source of this spec though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review