Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661436 --- Comment #10 from Minnikhanov <minnikhanov@xxxxxxxxx> 2010-12-13 13:34:37 EST --- (In reply to comment #4) > Some notes: > > * Unused macros > - The defined macro %ruby_sitelib is used nowhere. > - Please use the defined %geminstdir macro also in %files > > * License > - The license is MIT > > * source URL > - Please specify the full URL for Source0 > https://fedoraproject.org/wiki/Packaging/SourceURL > > * BuildRoot > - On Fedora BuildRoot line is no longer needed: > https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag > > * documents / -doc subpackage > - Please consider to split document files (which are not > needed on runtime) to -doc subpackage. > The following files/directories can be moved to -doc subpackage > ------------------------------------------------------ > %{gemdir}/doc/%{gemname}-%{version}/ > %{geminstdir}/spec/ > ------------------------------------------------------ > - Please mark %geminstdir/README.md as %doc correctly. Fix all notes. Check doc-subpackage thoroughly - this my 1st subpackage. :-) rpmlint - no error. [pkg@lhost SPECS]$ rpmlint rubygem-heroku.spec rubygem-heroku.spec: W: no-cleaning-of-buildroot %clean rubygem-heroku.spec: W: no-buildroot-tag rubygem-heroku.spec: W: no-%clean-section 0 packages and 1 specfiles checked; 0 errors, 3 warnings. [pkg@lhost SPECS]$ rpmbuild -ba rubygem-heroku.spec - no error. Wrote: /home/pkg/rpmbuild/SRPMS/rubygem-heroku-1.14.8-1.fc14.src.rpm Wrote: /home/pkg/rpmbuild/RPMS/noarch/rubygem-heroku-1.14.8-1.fc14.noarch.rpm Wrote: /home/pkg/rpmbuild/RPMS/noarch/rubygem-heroku-doc-1.14.8-1.fc14.noarch.rpm Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.PF0kb5 + umask 022 + cd /home/pkg/rpmbuild/BUILD + /bin/rm -rf /home/pkg/rpmbuild/BUILDROOT/rubygem-heroku-1.14.8-1.fc14.x86_64 + exit 0 [pkg@lhost SPECS]$ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review