Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657519 --- Comment #5 from Lubomir Rintel <lkundrak@xxxxx> 2010-12-12 14:32:23 EST --- (In reply to comment #4) > It's good the tests are enabled but the comment > now no longer makes sense, can you delete or change the case --without tests > works or something. Whoops; removed. > Also you can add > > %{?perl_default_subpackage_tests} > > after the preamble to build a subpackage of tests as well but this is up > to you. Well, quite honestly I did not know this macro exists; never seen it before. I'd prefer not adding it now, but would gladly add it (to other perl packages as well) once a guideline about its usage exists. SPEC: http://v3.sk/~lkundrak/SPECS/perl-Sys-Statistics-Linux.spec SRPM: http://v3.sk/~lkundrak/SRPMS/perl-Sys-Statistics-Linux-0.59-1.fc14.src.rpm (Sorry for not bumping a release number; the change seemed a bit too tiny to me :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review