Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657519 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |steve.traylen@xxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |steve.traylen@xxxxxxx Flag| |fedora-review? --- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> 2010-12-12 05:22:14 EST --- Review of perl-Sys-Statistics Dec 22nd 2010. Builds okay in mock F15. $ rpmlint perl-Sys-Statistics-Linux.spec /var/lib/mock/fedora-rawhide-x86_64/result/perl-Sys-Statistics-Linux-0.42-2.fc15.* perl-Sys-Statistics-Linux.spec: W: invalid-url Source0: http://www.cpan.org//authors/id/B/BL/BLOONIX/Sys-Statistics-Linux-0.42.tar.gz HTTP Error 404: Not Found perl-Sys-Statistics-Linux.noarch: W: spelling-error %description -l en_US informations -> information, information's, in formations perl-Sys-Statistics-Linux.src: W: spelling-error %description -l en_US informations -> information, information's, in formations perl-Sys-Statistics-Linux.src: W: invalid-url Source0: http://www.cpan.org//authors/id/B/BL/BLOONIX/Sys-Statistics-Linux-0.42.tar.gz HTTP Error 404: Not Found - Package meets naming and packaging guidelines Yes. - Spec file matches base package name. Yes, perl style. - Spec has consistant macro usage. Yes - Meets Packaging Guidelines. Yes - License GPL+ or Artistic - License field in spec matches Yes very clearly same as perl. - License file included in package Yes LICENCE file included. - Spec in American English - Spec is legible. - Sources match upstream md5sum: *FAIL* Can't be checked. http://www.cpan.org//authors/id/B/BL/BLOONIX/Sys-Statistics-Linux-0.42.tar.gz - Package needs ExcludeArch It does not. - BuildRequires correct Not tested with test. - Spec handles locales/find_lang Does not need to. - Package is relocatable and has a reason to be. Not relocatable. - Package has %defattr and permissions on files is good. It does. - Package has a correct %clean section. It does. - Package has correct buildroot It does. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content. Yes. - Doc subpackage needed/used. Not nescesary. - Packages %doc files don't affect runtime. They don't. - Headers/static libs in -devel subpackage. Not needed - Spec has needed ldconfig in post and postun Not needed - .pc files in -devel subpackage/requires pkgconfig Not needed - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file Not needed - Package compiles and builds on at least one arch. Mock - Package has no duplicate files in %files. None. - Package doesn't own any directories other packages own. - Package owns all the directories it creates. - No rpmlint output. - final provides and requires are sane: $ for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done perl-Sys-Statistics-Linux-0.42-2.fc15.noarch.rpm perl(Sys::Statistics::Linux) = 0.42 perl(Sys::Statistics::Linux::Compilation) = 0.07 perl(Sys::Statistics::Linux::CpuStats) = 0.15 perl(Sys::Statistics::Linux::DiskStats) = 0.19 perl(Sys::Statistics::Linux::DiskUsage) = 0.09 perl(Sys::Statistics::Linux::FileStats) = 0.06 perl(Sys::Statistics::Linux::LoadAVG) = 0.06 perl(Sys::Statistics::Linux::MemStats) = 0.13 perl(Sys::Statistics::Linux::NetStats) = 0.15 perl(Sys::Statistics::Linux::PgSwStats) = 0.13 perl(Sys::Statistics::Linux::ProcStats) = 0.13 perl(Sys::Statistics::Linux::Processes) = 0.20 perl(Sys::Statistics::Linux::SockStats) = 0.06 perl(Sys::Statistics::Linux::SysInfo) = 0.06 perl-Sys-Statistics-Linux = 0.42-2.fc15 = perl(:MODULE_COMPAT_5.12.2) perl(Carp) perl(POSIX) perl(Sys::Statistics::Linux::Compilation) perl(Time::HiRes) perl(UNIVERSAL) perl(UNIVERSAL::require) perl(constant) perl(strict) perl(warnings) perl-Sys-Statistics-Linux-0.42-2.fc15.src.rpm = perl(Module::Build) SHOULD Items: - Should build in mock. It does. - Should build on all supported archs It's noarch, it should. - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. - Should have dist tag - Should package latest version It's not: http://search.cpan.org/~bloonix/Sys-Statistics-Linux-0.59/ - check for outstanding bugs on package. (For core merge reviews) Looking good and cpanget has done all the work. Issues: 1. The URL does not work. 2. There is a newer version available 0.59. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review