Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661961 --- Comment #1 from Steve Milner <smilner@xxxxxxxxxx> 2010-12-10 14:03:33 EST --- + = good - = bad o = informational + The package is named according to the Package Naming Guidelines + The spec file name matches the base package %{name}, in the format %{name}.spec - The package must meet the Packaging Guidelines (see rpmlint output and notes on %doc) + The package is licensed with a Fedora approved license and meet the Licensing Guidelines (GPLv3) + The License field in the package spec matches the actual license (GPLv3) - the file, containing the text of the license(s) for the package must be included in %doc (%doc is not being used by this package. It should be updated to use %doc) + The spec file must be written in American English + The spec file for the package MUST be legible + The sources used to build the package matches the upstream source $ md5sum kyotocabinet-1.2.27.tar.gz kyotocabinet-1.2.27-1.fc14.src/kyotocabinet-1.2.27.tar.gz 01da76d5989b67f5b16cf48b170247ff kyotocabinet-1.2.27.tar.gz 01da76d5989b67f5b16cf48b170247ff kyotocabinet-1.2.27-1.fc14.src/kyotocabinet-1.2.27.tar.gz + The package successfully compiles and builds into binary rpms on at least one primary architecture (x86) ? If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. + All build dependencies are listed in BuildRequires + The spec file MUST handle locales properly. (no locales) ? Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. + Packages does NOT bundle copies of system libraries + If the package is designed to be relocatable, the packager must state this fact in the request for review (not relocatable) o a later version of the software was released o %clean section is not required unless you will be building for EPEL and/or F12 or lower. o Consider if the the development documentation should be in a -doc package instead of in the devel package due to the amount of files (222) - rpmlint must be run on the source rpm and all binary rpms the build produces (see http://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath) $ rpmlint /usr/local/steve/rpmbuild/RPMS/i686/kyotocabinet-1.2.27-1.fc13.i686.rpm /usr/local/steve/rpmbuild/RPMS/i686/kyotocabinet-devel-1.2.27-1.fc13.i686.rpm /usr/local/steve/rpmbuild/RPMS/i686/kyotocabinet-debuginfo-1.2.27-1.fc13.i686.rpm kyotocabinet-1.2.27-1.fc14.src.rpm kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kcforestmgr ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kcdirmgr ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kchashmgr ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kcforesttest ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kcstashtest ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kccachetest ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kchashtest ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kctreemgr ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kclangctest ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kcutilmgr ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kcdirtest ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kcutiltest ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kcpolytest ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kcprototest ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kcgrasstest ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kcpolymgr ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] kyotocabinet.i686: E: binary-or-shlib-defines-rpath /usr/bin/kctreetest ['/lib', '/usr/lib', '/usr/lib', '/usr/local/steve/lib', '/usr/local/lib', '/usr/lib'] 4 packages and 0 specfiles checked; 17 errors, 0 warnings. $ Once the above items are fixed I'll continue reviewing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review