Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=660625 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hdegoede@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Hans de Goede <hdegoede@xxxxxxxxxx> 2010-12-07 10:58:25 EST --- Full review done: Good: - rpmlint checks return: techne.src: W: no-cleaning-of-buildroot %clean techne.src: W: no-buildroot-tag techne.src: W: no-%clean-section techne.src: W: invalid-url Source0: http://download.savannah.gnu.org/releases/techne/techne-0.2.tar.gz HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 0 errors, 4 warnings. The first 3 can be ignored, for the last one see below - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+) OK, text in %doc, matches source - spec file legible, in am. english - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file MUST FIX / needs work: - sources match upstream I cannot verify this, please ask upstream to put a pre-release / alpha / beta tarbal somewhere. - owns all directories that it creates Currently the package does not own the following dirs: %{_libdir}/%{name} %{_datadir}/%{name} %{_datadir}/%{name}/common This can be fixed by replacing (in %files) this: %{_libdir}/%{name}/*.so %{_libdir}/%{name}/*.bin %{_datadir}/%{name}/common/* With: %{_libdir}/%{name} %{_datadir}/%{name} - release field not properly used. Since this is a pre release version being used the release field should be something like: Release: 0.1%{?dist} or: Release: 0.1.beta1%{?dist} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review