Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-PhpDocumentor Alias: phpDocumentor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201502 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2006-12-03 19:58 EST ------- sorry this took so long. I totally spaced :( Anyways. Building from the new spec, looks like the issues talked about previously have been addressed. rpmlint does complain a bit: [build@zeus php-pear-PhpDocumentor]$ rpmlint php-pear-PhpDocumentor-1.3.0-0.3.fc5.src.rpm W: php-pear-PhpDocumentor no-%build-section Easily rectifyable by including an empty %build section... ** phpdoc-1.3.0-0.3.fc5.noarch.rpm == rpmlint E: phpdoc subdir-in-bin /usr/bin/scripts/makedoc.sh == provides phpdoc = 1.3.0-0.3.fc5 == requires /bin/bash /usr/bin/php php-pear(PhpDocumentor) = 1.3.0 provides/requires looks sane. The error is well taken however; on examination it would appear that /usr/bin/scripts is better placed in %doc. ** php-pear-PhpDocumentor-1.3.0-0.3.fc5.noarch.rpm == rpmlint == provides php-pear(PhpDocumentor) = 1.3.0 php-pear-PhpDocumentor = 1.3.0-0.3.fc5 == requires /bin/sh /bin/sh /usr/bin/pear /usr/bin/pear php-pear(PEAR) ** php-pear-PhpDocumentor-docs-1.3.0-0.3.fc5.noarch.rpm == rpmlint W: php-pear-PhpDocumentor-docs wrong-file-end-of-line-encoding /usr/share/doc/php-pear-PhpDocumentor-docs-1.3.0/Documentation/Release-old/Release-0.3.0 == provides php-pear-PhpDocumentor-docs = 1.3.0-0.3.fc5 == requires php-pear-PhpDocumentor = 1.3.0-0.3.fc5 Again, requires/provides look sane for both packages; the rpmlint warning is well taken. I note the release is still in the "0.x" format... Fine for now, but I trust it'll be corrected before check-in. So, address the rpmlint warnings/errors and the odd placement of scripts/, and I'll approve. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review