Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654374 --- Comment #20 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxxxxxxxx> 2010-12-05 16:34:49 EST --- Package seems almost ready, with one major issue and several minor ones remaining. Major: source tarball does not match result of SVN export. The reordering is not a big deal, but the checkout I get uses lowercase is_nan whereas yours use uppercase is_nan. Since this is referred to in the patch files, it probably should be fixed (The file ordering problem can probably only be fixed by using git-svn instead of svn, and then using git archive instead of svn export, but as long as the recursive diff matches I'd consider the source tarball to match) Minor: incomplete directory ownership. See below. * TODO Review [54%] ** DONE Names [3/3] *** DONE Package name *** DONE Spec name *** DONE Package version [2/2] **** DONE Version number **** DONE Release tag ** DONE Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] ** FAIL Source files match upstream Contents do not match: $ diff -ru navit-3732 ~/rpmbuild/SOURCES/navit-3732 diff -ru navit-3732/navit/vehicle/gpsd_dbus/vehicle_gpsd_dbus.c /home/michel/rpmbuild/SOURCES/navit-3732/navit/vehicle/gpsd_dbus/vehicle_gpsd_dbus.c --- navit-3732/navit/vehicle/gpsd_dbus/vehicle_gpsd_dbus.c 2010-11-22 15:51:07.994297000 +0100 +++ /home/michel/rpmbuild/SOURCES/navit-3732/navit/vehicle/gpsd_dbus/vehicle_gpsd_dbus.c 2010-11-28 09:11:53.000000000 +0100 @@ -86,9 +86,9 @@ priv->geo.lat=latitude; priv->geo.lng=longitude; } - if (!is_nan(track)) + if (!is_NaN(track)) priv->track=track; - if (!is_nan(speed)) + if (!is_NaN(speed)) priv->speed=speed; if (!isnan(altitude)) priv->altitude=altitude; ** TODO [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]] ** DONE License [4/4] *** DONE License is Fedora-approved *** DONE No licensing conflict Remember not to enable espeak support *** DONE License field accurate *** DONE License included iff packaged by upstream ** TODO rpmlint [/] *** TODO on src.rpm $ rpmlint ~/Downloads/navit-0.5.0-0.1.20101128svn3732.fc14.src.rpm navit.src: W: spelling-error %description -l en_US gpsd -> Gypsy, gypsy, gramps navit.src:6: W: macro-in-comment %{name} => can be ignored navit.src:17: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 17) => should be fixed navit.src: W: invalid-url Source0: http://downloads.sourceforge.net/navit/navit-3732.tar.bz2 HTTP Error 404: Not Found => probably comment out this Source line when using a snapshot tarball 1 packages and 0 specfiles checked; 0 errors, 4 warnings. *** TODO on x86_64.rpm $ rpmlint ~/Downloads/navit-*.x86_64*.rpm navit.x86_64: W: spelling-error %description -l en_US gpsd -> Gypsy, gypsy, gramps navit-graphics-qt.x86_64: W: spelling-error %description -l en_US xml -> XML, cml, ml navit-graphics-qt.x86_64: W: no-documentation navit-graphics-sdl.x86_64: W: spelling-error %description -l en_US xml -> XML, cml, ml navit-graphics-sdl.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 5 warnings. => All harmless ** DONE Language & locale [3/3] *** DONE Spec in US English *** DONE Spec legible *** DONE Use %find_lang to handle locale files ** TODO Build [2/3] *** DONE Koji results *** DONE BRs complete *** FAIL Directory ownership - Nobody owns %dir %{_sysconfdir}/navit - Should Require: hicolor-icon-theme for /usr/share/icons ** TODO Spec inspection [8/9] *** N/A ldconfig for libraries *** DONE No duplicate files *** DONE File permissions *** DONE Filenames must be UTF-8 *** WAIT no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting EPEL5]]) BuildRoot can be removed, but it's harmless *** DONE Has %clean section (except F-13+: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) *** DONE %buildroot cleaned on %install *** DONE Macro usage consistent *** DONE Other subpackages ** DONE Desktop file validation ** DONE [[http://fedoraproject.org/wiki/Packaging/ScriptletSnippets][Scriptlets]] [4/4] *** N/A desktop-database (desktop entry has MimeType) *** DONE icon cache (icons in %{_datadir}/icons/) *** N/A info files *** N/A mimeinfo (file in %{_datadir}/mime/packages) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review