Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=660095 --- Comment #5 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-12-05 10:56:00 EST --- Okay, if it's the standard for opengl-games-utils, then that's okay.. Although, the only thing you'd need to modify is SOURCE1, since the stuff in opengl-game-utils doesn't care at all about impressive. Actually there is a bug in the current implementation: the wrapper has APP=python-impressive checkDriOK $APP which will print "Therefore python-impressive cannot run." if DRI support is missing, when it actually should print "Therefore impressive cannot run." If you place the python script in %{python_sitelib}, you'll just have to change SOURCE 1 to e.g. #!/bin/bash . /usr/share/opengl-games-utils/opengl-game-functions.sh APP=impressive checkDriOK $APP exec @PYTHONSITELIB@/$APP.py "$@" and you'll have to install it with sed "s|@PYTHONSITELIB@|%{python_sitelib}|g" %{SOURCE1} > %{buildroot}%{bindir}/impressive but this isn't a problem anyway. The added convenience of installing into python_sitelib is that RPM will compile the python file into bytecode, so execution will be (marginally) faster. (In reply to comment #4) > > This is a Python package, so you should add BuildRequires: python-devel to make > > sure everything goes alright. > > This package does not build anything and does not use setup.py etc. > (distutils). Maybe it should, but it doesn't... > It's a single standalone python file/program (save the wrapper). Nonetheless, you need python-devel so that the macros are declared and so that the bytecode compilation takes place (IIRC). Doesn't hurt having it, anyhow. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review