[Bug 659756] Review Request: libnfsidmap - Library that handles mapping between names and ids for NFSv4.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=659756

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx

--- Comment #9 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2010-12-05 07:08:29 EST ---
Provided the speed this review was rushed through, I can't deny having uneasy
feeling about this review (Pingpong match?).

Package is not OK:

- ChangeLog date is wrong:
 .. * Fri Dec  3 2006 ...

- Superfluous BR's:
 .. BR: autoconf, automake

- Package supplies *.pc's => Package must own %{_libdir}/pkgconfig
(recent FPG change)

- Hard-coded /etc at several places.
Should be %{_sysconfdir}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]