Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libindicator - Shared functions for Ayatana indicators https://bugzilla.redhat.com/show_bug.cgi?id=659812 Summary: Review Request: libindicator - Shared functions for Ayatana indicators Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@xxxxxxxxxxxxxxxxx ReportedBy: awilliam@xxxxxxxxxx QAContact: extras-qa@xxxxxxxxxxxxxxxxx CC: notting@xxxxxxxxxx, fedora-package-review@xxxxxxxxxx Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://www.happyassassin.net/extras/libindicator.spec SRPM URL: http://www.happyassassin.net/extras/libindicator-0.3.15-1.fc15.src.rpm Description: A set of symbols and convenience functions that all Ayatana indicators are likely to use. This is part of packaging Unity for Fedora. The only odd thing about the build is that we build the lib twice, to have a GTK+ 2 and a GTK+ 3 build, so GTK+2 and GTK+3 apps can both use the indicator framework. This is explicitly intended and supported by upstream. The patches, as noted, come from upstream and fix a couple of things for this building-both-libraries process. rpmlint output: [adamw@adam result]$ rpmlint *.rpm libindicator.src:86: W: configure-without-libdir-spec libindicator.src: W: no-cleaning-of-buildroot %clean libindicator.src: W: no-buildroot-tag libindicator.src: W: no-%clean-section libindicator-devel.x86_64: W: non-conffile-in-etc /etc/X11/Xsession.d/80indicator-debugging 8 packages and 0 specfiles checked; 0 errors, 5 warnings. the configure-without-libdir is a false positive that comes when re-defining _configure for out-of-tree building (necessary to do the two builds). The actual configure statements are correct. non-conffile-in-etc is okay, the file isn't really intended to be modified (it just sets some values to aid in developer debugging, which is why it's packaged in the -devel package; this is how Ubuntu packages it too). The others are okay for F13+ (F12 is EOL). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review