Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=649425 --- Comment #3 from Dmitrij S. Kryzhevich <krege@xxxxxxx> 2010-12-03 01:23:52 EST --- (In reply to comment #2) > == Notes == > * BuildRequires: gtk2 seems wrong. I did a scratch build without it > (http://koji.fedoraproject.org/koji/taskinfo?taskID=2639728) and it built fine > (as expected). You should remove it from your final package. Ah, gtk2 is dependece of some other package. It does not need to be metioned explicitly. > * %clean is unnecessary in active Fedora targets, see: > https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean (it is still > needed if you need this package for EPEL) This and following are from F12 wich was not EOL at submiting this review. Spec and srpm updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review