Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646637 --- Comment #5 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2010-12-02 10:21:15 EST --- OK thanks for the feedback and srry for the delay (was off all last week). Updated package to: 1. include pom.xml and run the maven macros 2. install jar and javadocs as %{name} and not %{name}-%{version} 3. execute one 'ant jar javadoc' command (good catch, thx for this) I still left the javadoc subpackage depending on the main one to keep consistency w/ all the other jruby packages. If this poses to be a big issue in the future we can just update the package. Spec URL: http://mo.morsi.org/files/jruby/jnr-netdb.spec SRPM URL: http://mo.morsi.org/files/jruby/jnr-netdb-1.0.1-3.fc13.src.rpm Again thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review