Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561477 --- Comment #7 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2010-12-02 09:53:59 EST --- OK thanks for the feedback and srry for the delay (was off all last week). Updated package to: 1. remove BuildRoot and clean section 2. Consistently use macros 3. jar and javadocs are now named %{name} and not %{name}-%{version} 4. installed pom.xml and used maven macros As far as the javadoc subpackage, it already depends on the main package, so I think this isn't an issue (please elaborate if so). Also I'm just going to leave it as ant for now as thats the quickest way to get this is and is still standards compliant, we can update the package if this ever becomes an issue. Updated SPEC and SRPM: Spec URL: http://mo.morsi.org/files/jruby/jnr-posix.spec SRPM URL: http://mo.morsi.org/files/jruby/jnr-posix-1.1.4-3.fc13.src.rpm Again thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review