Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608509 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #9 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2010-12-01 18:52:25 EST --- While reviewing this I noticed that you've submitted around 138 packages (158 minus about 20 duplicates and reviews that were closed for various reasons) while reviewing only 38. Since I have no package submissions pending, would you consider doing the courtesy of reviewing someone else's package? If you do, I'll look at some of your other pending submissions. Builds fine; rpmlint complains only about the lack of a manpage for subvertpy-fast-export. I'm afraid I don't understand why the tests directory is part of the final package. What purpose does it serve? * source files match upstream. sha256sum: c43782ef281f347a1c4fe02e5cab4dd361fe228a6c3186f2d76ec01daca9bb5e subvertpy-0.7.5.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: python-subvertpy = 0.7.5-2.fc15 python-subvertpy(x86-64) = 0.7.5-2.fc15 = libapr-1.so.0()(64bit) libpython2.7.so.1.0()(64bit) libsvn_client-1.so.0()(64bit) libsvn_delta-1.so.0()(64bit) libsvn_fs-1.so.0()(64bit) libsvn_ra-1.so.0()(64bit) libsvn_repos-1.so.0()(64bit) libsvn_subr-1.so.0()(64bit) libsvn_wc-1.so.0()(64bit) python(abi) = 2.7 /usr/bin/python * %check is present and all tests pass: Ran 129 tests in 25.772s OK * no bundled libraries. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no static libraries. * no libtool .la files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review