Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648945 --- Comment #7 from Deepak Bhole <dbhole@xxxxxxxxxx> 2010-12-01 10:53:55 EST --- Okay, everything seems to be in order. I tried to build atinject and it went smoothly. So here is the full review for the latest posted files (comment #2): PASSED: Package name is OK License is OK Release is consistent with guidelines Source verified Patches are OK No typos found in summary/description BuildRoot is OK {?dist} used correctly License is marked %doc FHS guidelines met Package/Vendor/Distribution tags not used No use of 'Copyright' Summary does not end in period Post and Postun reqs used correctly Package compiled on x86_64 Summary and description are < 80 chars %clean present cp -a used, which preserves timestamps Package owns all files and dirs No duplicates in %files FAILED: No prebuilt binaries- FAILED - There is a apache-maven-3.0/maven-ant-tasks-2.1.1.jar that is also in the buildroot. RPMLint on built packages - FAILED - As discussed above, /etc/maven/fragments/maven should be %config -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review