Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=658796 --- Comment #8 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2010-12-01 08:26:27 EST --- (In reply to comment #7) > I've addressed all the above (and updates the svn repo) but the CFLAGS issue as You should drop these lines now: cp -p %{_builddir}/%{name}-%{version}/COPYRIGHT %{buildroot}%{_defaultdocdir}/%{name}-%{version} cp -p %{_builddir}/%{name}-%{version}/README %{buildroot}%{_defaultdocdir}/%{name}-%{version} cp -p %{_builddir}/%{name}-%{version}/RELEASE_NOTES %{buildroot}%{_defaultdocdir}/%{name}-%{version} cp -p %{_builddir}/%{name}-%{version}/ChangeLog %{buildroot}%{_defaultdocdir}/%{name}-%{version} You already marked these files as %doc so they will be picked up right from the %{_builddir}/%{name}-%{version} by rpmbuild. Also ther is no need to explicitly mention %{_builddir}/%{name}-%{version} everytime in the %install section - you already in %{_builddir}/%{name}-%{version} so this prefix may be omitted. > I can't see anything in my rpmbuild output, can you expand pls so I can address > this? Yes, sure. Take a look at the build log from the koji link above: http://koji.fedoraproject.org/koji/getfile?taskID=2636505&name=build.log See - no extra compiler's options were passed to ${CC}. You must explicitly set CFLAGS before make invocation: CFLAGS="%{optflags}" make ptpd Another one issue which brings my attention is 3-fold extraction of %{SOURCE0}. This looks somewhat excessive and should be fixed as well. I adwice you to change %prep section as follows: %prep # extract first source implicitly and add in fedora init script and sysconfig %setup -a 1 Also you may just list these two files as %{SOURCE1} and %{SOURCE2} and just copy them directly in the %install section w/o touching them during %prep stage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review