Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655599 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #11 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-11-30 08:47:58 EST --- (In reply to comment #10) > (In reply to comment #9) > > The description is confusing: > > "This package contains the plugins for Remmina." > > But 'this package' doesn't require it. So if you want to install all plugins > > with yum install remmina-plugins it won't work. > > How about requiring the subpackages all together to get that functionality? > > (just a MAYBE, not even a SHOULD) > > As you can see from %files there is no remmina-plugins binary, the description > is only for the SRPM. For the SRPM I consider the description correct, but I > don't want to build a meta-package. Meta-packages are discouraged in Fedora. Yes, I was thinking of a meta-package and the description sounds like one. But ok ;-) > > BLOCKER: > > - remmina-plugins bundles libvncserver, so you need an exception from FPC > > (or am I wrong here?) > > Yes and no. :)If I were to use the bundled library, I'd need an exception. But > thankfully I just need to use add "--enable-vnc=dl" (=dynamic library), then > configure looks like this: > > Remmina-Plugins configure result: > > * RDP plugin: yes > * VNC plugin: link to libvncclient externally > * XDMCP plugin: yes > * NX plugin: yes > * Telepathy plugin: yes > > This got lost during the transition from remmina to remmina-plugins. Thanks for > catching this! Ok, please try to delete the folder libvncserver in %prep, just to be sure it's not used ;-) __________________________________________________________________________ APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review