Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655599 --- Comment #9 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-11-30 07:48:24 EST --- The missing plural 's' was my 'spelling error' from above... Thanks for fixing it :-) Review: - name ok - spec readable - %files ok - all packages require the common package -> licensing deps ok - BR ok - R seem ok - no static libs - no *.la - lang correctly installed - optflags used - parallel make - preserving timestamps everywhere - macros everywhere - rpmlint ok (22 wrong spelling errors and wrong no-documentaion) - source matches upstream: 873f1cf8afb46a911e1a4bd90d776f15 - license GPLv2+ ok (maybe) TODO: The description is confusing: "This package contains the plugins for Remmina." But 'this package' doesn't require it. So if you want to install all plugins with yum install remmina-plugins it won't work. How about requiring the subpackages all together to get that functionality? (just a MAYBE, not even a SHOULD) BLOCKER: - remmina-plugins bundles libvncserver, so you need an exception from FPC (or am I wrong here?) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review