Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656084 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-11-29 04:21:56 EST --- Spec file changes: --- perl-CDB_File.spec 2010-11-23 03:00:08.000000000 +0100 +++ perl-CDB_File.spec.1 2010-11-28 01:28:38.000000000 +0100 @@ -2,7 +2,7 @@ Name: perl-CDB_File Version: 0.96 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Perl extension for access to cdb databases License: GPL+ or Artistic Group: Development/Libraries @@ -10,6 +10,8 @@ Source0: http://www.cpan.org/authors/id/M/MS/MSERGEANT/CDB_File-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(Exporter) +BuildRequires: perl(Test) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %description @@ -50,5 +52,7 @@ %{_mandir}/man3/* %changelog +* Sat Nov 27 2010 Mark McKinstry <mmckinst@xxxxxxxxxxx> 0.96-2 +- add perl(Exporter) and perl(Test) as build requirements * Mon Nov 22 2010 Mark McKinstry <mmckinst@xxxxxxxxxxx> 0.96-1 - Initial packaging using cpanspec 1.78. (In reply to comment #3) > > FIX: BuildRequire perl(Exporter) as it can dual-live in the future > > (CDB_File.pm:8, http://search.cpan.org/~ferreira/Exporter/) > > FIX: BuildRequire perl(Test) as it can dual-live in the future (t/01main.t:2, > > http://search.cpan.org/~jesse/Test/) > > Done. > Ok. $ rpmlint perl-CDB_File.spec ../SRPMS/perl-CDB_File-0.96-2.fc14.src.rpm ../RPMS/x86_64/perl-CDB_File-0.96-2.fc14.x86_64.rpm perl-CDB_File.spec:13: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 13) perl-CDB_File.src: W: spelling-error Summary(en_US) cdb -> cd, db, cab perl-CDB_File.src: W: spelling-error %description -l en_US cdb -> cd, db, cab perl-CDB_File.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 13) perl-CDB_File.x86_64: W: spelling-error Summary(en_US) cdb -> cd, db, cab perl-CDB_File.x86_64: W: spelling-error %description -l en_US cdb -> cd, db, cab 2 packages and 1 specfiles checked; 0 errors, 6 warnings. TODO: Normalize white spaces in the spec file. rpmlint Ok. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2631600). Ok. Please consider to correct all `TODO' prefixed issues once committing the package into repository. Resolution: Package APPROVED. > Can you explain what exactly dual-live means Dual-lived package means a binary package is built from two SPEC files. Resulting binary packages have the same name (but differs in version) and package utilities (like yum) do not make differences between them. In perl, we use this approach to upgrade perl modules that come bundled with perl sources. Once user do an update, he needs to download and update only the one package. If we patched the main perl source package, it would change release number of all binary packages made from perl.spec and it would force everybody in update all the resulting binary packages (it counts in tens). Currently, not all modules bundled with perl have separate binary package, however we try to migrate to this schema as we are upgrading the modules. Bundled perl packages can be identified by searching CPAN. If there is standalone module name it can be separated into dual-lived RPM package some time. If CPAN points back to `perl' module, the perl module is not just bundled, it's part of perl interpreter sources. I pointed this fact by the URL in parentheses of my comments. > and how you figured out > perl(Test) and perl(Exporter) needed to be BuildRequires? I just greped sources for `use' and `require' keywords. Exact location is the first part inside parentheses of my comments. I know the cpanspec utility is not aware of it and does not do this exercise. I hope I find a free time to improve it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review