Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638590 Stanislav Ochotnicky <sochotni@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #18 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-11-29 04:01:59 EST --- I've looked at the package and see nothing that would prevent me from giving you a "+" :-) A few notes though (for future): * You have most things nicely aligned, but few lines are not (Name, Version, Buildarch...) * you are doing: mv jibx/jibxbind-1.2.2.jar jibx/jibx-bind.jar a more error-resilient form would be: mv jibx/jibxbind-*.jar jibx/jibx-bind.jar * you still have xml-commons-apis-1.4.01 (versioned) in build-jar-repository All of these are just small things that can be fixed with next package update. Thanks for good work on this! APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review