Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647510 --- Comment #8 from Joachim de Groot <jdegroot@xxxxxx> 2010-11-27 10:51:50 EST --- Thank you for the review! I have updated the spec file: Spec URL: http://fedora.jaydg.nl/premake.spec SRPM URL: http://fedora.jaydg.nl/premake-4.3-1.fc14.src.rpm Changes: - packed latest version - changes license to BSD - added readline-devel to BuildRequires - added a man page - do not clean %{_builddir}/%{buildsubdir} - added version-release pair to changelog rpmlint is silent now: 2 packages and 1 specfiles checked; 0 errors, 0 warnings. The provided test suite could be run during the build, but unfortunately one test fails on x86_64, so I chose not to add it. I'll report the bug upstream and run the tests when it has been fixed: os.findlib_FindSystemLib: /home/joachim/tmp/premake-4.3/tests/base/test_os.lua:18: expected true but was false 600 tests passed, 1 failed I'm not sure about the symlink, as upstream calls the current version premake4 throughout the documentation and chosen this name as the scripts for version 4 are incompatible to scripts for the previous versions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review